Update Adikteev adapter (PR updated) #3391

piotr-yuxuan · 2018-12-18T15:53:34Z

Type of change

Adapter feature update
This change affects user-facing APIs or examples documented on http://prebid.org.

Description of change

Test parameters for validating bids

{
    bidder: 'adikteev',
    params: {
       adSpaceId: 5084
    }
}

Integration tested with Adikteev's Hello World sample page.
Maintainer: adnetwork@adikteev.com
PR on the docs repo

modules/adikteevBidAdapter.js

mike-chowla · 2019-01-12T01:27:33Z

I'm getting an HTTP 503 back when I tried to test this with your sample page

modules/adikteevBidAdapter.js

piotr-yuxuan · 2019-01-17T17:43:41Z

@mike-chowla it should be OK and respond with code 200 now. Thanks for your review 🙂

mike-chowla · 2019-01-30T01:50:02Z

I tried it again I'm still not getting any bid back.

Here's the POST body your adapter is sending:
{ "akPbjsVersion":"1.35.0", "bidRequests":[ { "params":{ "placementId":51901 }, "crumbs":{ "pubcid":"bd0be225-d934-4295-9cf8-87ee393c6a63" }, "sizes":[ [ 300, 250 ], [ 250, 300 ], [ 300, 600 ] ], "bidId":"20264b24e0467f", "bidderRequestId":"1369966f2bf47" } ], "debug":false, "language":"en-US", "refererInfo":{ "referer":"http://mike.pubmatic.com:9999/integrationExamples/gpt/hello_world_adikteev.html", "reachedTop":true, "numIframes":0, "stack":[ "http://mike.pubmatic.com:9999/integrationExamples/gpt/hello_world_adikteev.html" ] }, "deviceInfo":{ "browserWidth":1468, "browserHeight":534, "deviceWidth":1920, "deviceHeight":1080, "documentWidth":1468, "documentHeight":534, "webGL":true }, "userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36" }

piotr-yuxuan · 2019-02-01T13:08:38Z

My bad @mike-chowla, sorry for the delay. I thought it was only needed to send response code 200 with an (empty) array of bid responses. Now it returns a real bid from our system.

Something has changed, now tests must asynchronously set config.

piotr-yuxuan · 2019-02-14T17:56:19Z

Hi there,

master has seen quite a lot of changes since this branch has been created two months ago, so tests code got broken. I've had to rebase this branch on upstream master and repair the tests. In addition to that fix, I've added some additional changes we need.

@mike-chowla In order to ease our integration, would you like to review this PR again? It's been some time we haven't heard from you. I'll be more than happy to do whatever is needed to get this PR merged 🙂

Cheers.

mike-chowla

No add is rendering with the test parameters due to the bid getting dropped.

Also, please change the PR comments to reflect the correct test parameters (adSpaceId)

modules/adikteevBidAdapter.js

mike-chowla · 2019-02-19T15:07:29Z

Apologies for the slow response. I've been traveling the last couple of weeks and have gotten behind on my PR reviews

piotr-yuxuan · 2019-02-19T16:56:15Z

Hey! Thank you very much for your reply.

Here is how I test it. I launch gulp serve from commit dcca2b6, then I browse to http://localhost:9999/integrationExamples/gpt/hello_world_adikteev.html and I can see an ad displayed in the page.

Chrome network dev tools show there is a call to https://prebid.adikteev.com/api/prebid/bid, and here is the raw response I've just got:

[{"netRevenue":true,"width":300,"currency":"EUR","requestId":"2638a6b3ee42ba","creativeId":41601,"ttl":360,"ad":"<div><img height=\"1\" src=\"https://event-adserver.adikteev.com/api/ad_event.json?ad_space_id=5084&amp;sdk_version=8452&amp;what=on_ad_ready_by_sdk&amp;campaign_id=41601&amp;placement_id=46528&amp;device=351d362a-b9ce-4759-af4e-420870263dae&amp;ip=84.14.114.166\" style=\"display:none;visibility:hidden;\" width=\"1\" /><iframe src=\"https://serve-adserver.adikteev.com/api/prebid/serve?ad_space_id=5084&amp;bid_id=2638a6b3ee42ba&amp;sdk_version=9001&amp;placement_id=46528&amp;creative_id=41601\" style=\"background::transparent;border:0;height:100%;margin:0;overflow::hidden;padding:0;width:100%;\"></iframe></div>","cpm":3.325,"height":250}]

Once formatted it becomes:

[{
  "netRevenue": true,
  "width": 300,
  "currency": "EUR",
  "requestId": "2303a14333cf4f",
  "creativeId": 41601,
  "ttl": 360,
  "ad": "<div><img height=\"1\" src=\"https://event-adserver.adikteev.com/api/ad_event.json?ad_space_id=5084&amp;sdk_version=8452&amp;what=on_ad_ready_by_sdk&amp;campaign_id=41601&amp;placement_id=46528&amp;device=e61b94de-4714-4f57-ab3e-6b83f3669f9c&amp;ip=84.14.114.166\" style=\"display:none;visibility:hidden;\" width=\"1\" /><iframe src=\"https://serve-adserver.adikteev.com/api/prebid/serve?ad_space_id=5084&amp;bid_id=2303a14333cf4f&amp;sdk_version=9001&amp;placement_id=46528&amp;creative_id=41601\" style=\"background::transparent;border:0;height:100%;margin:0;overflow::hidden;padding:0;width:100%;\"></iframe></div>",
  "cpm": 3.325,
  "height": 250
}]

Am I missing something?

piotr-yuxuan · 2019-02-21T01:34:48Z

It seems that adikteev_response.txt content doesn't come from us.

piotr-yuxuan · 2019-02-21T23:23:25Z

Anything I can do to help review this PR? I know it's not enough for this PR to WorkOnMyMachine® 😉 but I'm unsure what I can do more.

mike-chowla · 2019-02-22T04:24:17Z

I tried this again but still getting no bids back.

Request URL: https://prebid.adikteev.com/api/prebid/bid

Request Body:
adikteev_request.txt

piotr-yuxuan · 2019-02-22T09:28:55Z

OK, I believe I got it. The ad set up for Prebid was restricted in some countries. Please accept my apologies for that! At least it demonstrates we run our actual ad engine and give an actual response, not a canned one 🙂

mike-chowla · 2019-02-26T17:04:35Z

There's a CORS issue when retreiving the bid:

piotr-yuxuan · 2019-02-27T10:55:18Z

Well, this error 500 was because of the update of some campaign. Should be alright now.

piotr-yuxuan · 2019-03-05T10:01:00Z

Hey, anything new on here?

I've compiled Prebid on commit 537698d with command gulp build --modules=adikteevBidAdapter and put the prebids.js output file here: https://s3-eu-west-1.amazonaws.com/cdn.adikteev.com/prebid.js.

I've put the integration code page of ./integrationExamples/gpt/hello_world_adikteev.html in a jsFiddle example: https://jsfiddle.net/zu57k1t8/ to figure out whether the current state of code of our system allows for a bid to be won. I run it on Tor to test it from anywhere in the world. Of course, in Tor I allow all JavaScript to run without any restriction.

So far it's been working for the last 7 days. Any feedback on your side?

Cheers.

For the sake of completion, here are:

POST request to https://prebid.adikteev.com/api/prebid/bid

curl 'https://prebid.adikteev.com/api/prebid/bid' -H 'Referer: https://fiddle.jshell.net/' -H 'Origin: https://fiddle.jshell.net' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3724.0 Safari/537.36' -H 'Content-Type: text/plain' --data-binary '{"akPbjsVersion":"1.35.0","bidRequests":[{"params":{"adSpaceId":5084},"sizes":[[300,250],[250,300],[300,600]],"bidId":"2c59999bf0ef6e","bidderRequestId":"1b34f78400deb2"}],"debug":false,"language":"en-GB","refererInfo":{"referer":"https://jsfiddle.net/","reachedTop":true,"numIframes":1,"stack":["https://jsfiddle.net/","https://fiddle.jshell.net/kx0s3eLa/9/show/"]},"deviceInfo":{"browserWidth":1175,"browserHeight":294,"deviceWidth":2560,"deviceHeight":1440,"documentWidth":1175,"documentHeight":294,"webGL":true},"userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3724.0 Safari/537.36"}' --compressed

Beautified response

[
  {
    "netRevenue": true,
    "width": 300,
    "currency": "EUR",
    "requestId": "2c59999bf0ef6e",
    "creativeId": 41601,
    "ttl": 360,
    "ad": "<div><img height=\"1\" src=\"https://event-adserver.adikteev.com/api/ad_event.json?ad_space_id=5084&amp;sdk_version=8452&amp;what=on_ad_ready_by_sdk&amp;campaign_id=41601&amp;placement_id=46528&amp;device=1459c8fa-cc89-4a77-9a64-9d2992aee474&amp;ip=84.14.114.166\" style=\"display:none;visibility:hidden;\" width=\"1\" /><iframe src=\"https://serve-adserver.adikteev.com/api/prebid/serve?ad_space_id=5084&amp;bid_id=2c59999bf0ef6e&amp;sdk_version=8452&amp;placement_id=46528&amp;creative_id=41601\" style=\"background::transparent;border:0;height:100%;margin:0;overflow::hidden;padding:0;width:100%;\"></iframe></div>",
    "cpm": 3.325,
    "height": 250
  }
]

piotr-yuxuan · 2019-03-05T10:06:00Z

Please let me know if you experience any hindrance whilst reviewing this PR, I'll be most glad to help you.

piotr-yuxuan · 2019-03-06T09:38:52Z

@mike-chowla 😉

piotr-yuxuan · 2019-03-08T01:08:18Z

up?

piotr-yuxuan · 2019-03-11T14:25:39Z

This PR is tagged with not receiving bids, which prevents it to get merged.

To the best of my knowledge it's been inaccurate for the last 12 days, except for short periods of time when we've deployed and rolled out some parts of our system.

@mike-chowla would you mind check it again? As said in an earlier comment, the integration page code has been put in a jsfiddle and tested on Tor, Firefox (with preset default security settings), and Chrome. The integration page also has been test locally with gulp, then visiting http://localhost:9999.

In all these cases the serving endpoint has been able to receive bids and respond to them, which leads me to think the PR tagging has been inaccurate for some days.

jaiminpanchal27

@piotr-yuxuan Verified bids getting back. Just one minor change in spec files.

test/spec/modules/adikteevBidAdapter_spec.js

prebid#2987

mike-chowla

LGTM

jeremyvdw · 2019-03-18T10:47:43Z

Hi @mike-chowla,
Thanks for your review.
Adikteev is now rebranded as eMoteev: https://twitter.com/Adikteev/status/1105073414103072769, https://www.linkedin.com/feed/update/urn:li:activity:6511615144966135809

We need to address the change in this PR for it to be relevant.
The following commit will reflect this rebranding, no more changes, as we would like to be merged and deployed ASAP.
Thank you.

PS: @jaiminpanchal27 if the change you requested suits you, would you like to approve it? Thx

- https://twitter.com/Adikteev/status/1105073414103072769 - https://www.linkedin.com/feed/update/urn:li:activity:6511615144966135809

Adikteev becomes Emoteev

piotr-yuxuan · 2019-03-18T11:29:28Z

For the sake of completion:

POST request to https://prebid.emoteev.io/api/prebid/bid

curl 'https://prebid.emoteev.io/api/prebid/bid' -H 'Referer: http://localhost:9999/integrationExamples/gpt/hello_world_emoteev.html' -H 'Origin: http://localhost:9999' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3736.0 Safari/537.36' -H 'Content-Type: text/plain' --data-binary '{"akPbjsVersion":"1.35.0","bidRequests":[{"params":{"adSpaceId":5084},"crumbs":{"pubcid":"6e040aab-46bd-45bc-b898-e1b72b62d75c"},"sizes":[[300,250],[250,300],[300,600]],"bidId":"2988189446fab3","bidderRequestId":"1d9d620ba0fc0c"}],"debug":false,"language":"en-GB","refererInfo":{"referer":"http://localhost:9999/integrationExamples/gpt/hello_world_emoteev.html","reachedTop":true,"numIframes":0,"stack":["http://localhost:9999/integrationExamples/gpt/hello_world_emoteev.html"]},"deviceInfo":{"browserWidth":1440,"browserHeight":150,"deviceWidth":1440,"deviceHeight":900,"documentWidth":1440,"documentHeight":150,"webGL":true},"userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3736.0 Safari/537.36"}' --compressed

Beautified response

[
  {
    "width": 300,
    "ad": "<div><img height=\"1px\" src=\"https://event-adserver.adikteev.com/api/ad_event.json?ad_space_id=5084&amp;sdk_version=8481&amp;what=on_ad_ready_by_sdk&amp;campaign_id=41601&amp;placement_id=58710&amp;device=1733e013-61aa-4063-b153-10ebdb360654&amp;ip=84.14.114.166\" style=\"display:none;visibility:hidden;\" width=\"1px\" /><iframe src=\"https://serve-adserver.adikteev.com/api/prebid/serve?ad_space_id=5084&amp;uid=136a7411-11a9-441d-a0d8-5c3e120ef0fd&amp;sdk_version=8481&amp;placement_id=58710&amp;creative_id=41601\" style=\"background:transparent;border:0;height:100%;margin:0;overflow:hidden;padding:0;width:100%;\"></iframe></div>",
    "height": 250,
    "currency": "EUR",
    "netRevenue": true,
    "requestId": "2988189446fab3",
    "ttl": 360,
    "cpm": 3.325,
    "creativeId": 41601
  }
]

Update Adikteev adapter (PR updated)

piotr-yuxuan force-pushed the update-adikteev-adapter branch from e7a1896 to f963440 Compare December 18, 2018 16:38

mike-chowla self-assigned this Dec 18, 2018

piotr-yuxuan force-pushed the update-adikteev-adapter branch from f963440 to eca62a6 Compare December 21, 2018 17:30

harpere added the needs review label Jan 3, 2019

mike-chowla reviewed Jan 8, 2019

View reviewed changes

modules/adikteevBidAdapter.js Outdated Show resolved Hide resolved

mike-chowla added not receiving bids and removed needs review labels Jan 12, 2019

mike-chowla reviewed Jan 12, 2019

View reviewed changes

modules/adikteevBidAdapter.js Outdated Show resolved Hide resolved

piotr-yuxuan changed the title ~~Update Adikteev adapter~~ Update Adikteev adapter (update: now receives bids) Feb 8, 2019

piotr-yuxuan added 7 commits February 14, 2019 17:59

Update Adikteev adapter

1685245

Drop unused document.cookie

29ef07e

Fix tests

8d5ff1d

Change example placementId

1899f5d

Update demo placementId

d4c945b

Use ad-space in spite of placement

95d7b95

Fix config usage after rebase

dcca2b6

Something has changed, now tests must asynchronously set config.

piotr-yuxuan force-pushed the update-adikteev-adapter branch from 1c83222 to dcca2b6 Compare February 14, 2019 17:38

piotr-yuxuan mentioned this pull request Feb 15, 2019

Update adikteev adapter (main PR now merged) prebid/prebid.github.io#1066

Merged

mike-chowla requested changes Feb 19, 2019

View reviewed changes

modules/adikteevBidAdapter.js Outdated Show resolved Hide resolved

Update modules/adikteevBidAdapter.md

537698d

piotr-yuxuan changed the title ~~Update Adikteev adapter (update: now receives bids)~~ Update Adikteev adapter (PR updated) Mar 5, 2019

jaiminpanchal27 requested changes Mar 15, 2019

View reviewed changes

test/spec/modules/adikteevBidAdapter_spec.js Outdated Show resolved Hide resolved

jaiminpanchal27 removed the not receiving bids label Mar 15, 2019

No arrow functions in spec

542b03f

prebid#2987

mike-chowla approved these changes Mar 15, 2019

View reviewed changes

jeremyvdw and others added 3 commits March 18, 2019 11:51

Adikteev becomes Emoteev

0a618c3

- https://twitter.com/Adikteev/status/1105073414103072769 - https://www.linkedin.com/feed/update/urn:li:activity:6511615144966135809

Merge pull request #2 from Adikteev/update-adikteev-adapter-rebranding

9a51611

Adikteev becomes Emoteev

Fix maintainer email

bd060b1

mike-chowla merged commit 033e76b into prebid:master Mar 24, 2019

piotr-yuxuan mentioned this pull request Mar 25, 2019

Improve emoteevBidAdapter #3673

Merged

9 tasks

pycnvr pushed a commit to conversant/Prebid.js that referenced this pull request Apr 4, 2019

Update Adikteev adapter (PR updated) (prebid#3391)

978cc04

Update Adikteev adapter (PR updated)

jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019

Update Adikteev adapter (PR updated) (prebid#3391)

c97df54

Update Adikteev adapter (PR updated)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Adikteev adapter (PR updated) #3391

Update Adikteev adapter (PR updated) #3391

piotr-yuxuan commented Dec 18, 2018 •

edited

Loading

mike-chowla commented Jan 12, 2019 •

edited

Loading

piotr-yuxuan commented Jan 17, 2019

mike-chowla commented Jan 30, 2019

piotr-yuxuan commented Feb 1, 2019 •

edited

Loading

piotr-yuxuan commented Feb 14, 2019 •

edited

Loading

mike-chowla left a comment

mike-chowla commented Feb 19, 2019

piotr-yuxuan commented Feb 19, 2019

piotr-yuxuan commented Feb 21, 2019 •

edited

Loading

piotr-yuxuan commented Feb 21, 2019

mike-chowla commented Feb 22, 2019

piotr-yuxuan commented Feb 22, 2019

mike-chowla commented Feb 26, 2019

piotr-yuxuan commented Feb 27, 2019

piotr-yuxuan commented Mar 5, 2019 •

edited

Loading

piotr-yuxuan commented Mar 5, 2019

piotr-yuxuan commented Mar 6, 2019

piotr-yuxuan commented Mar 8, 2019

piotr-yuxuan commented Mar 11, 2019 •

edited

Loading

jaiminpanchal27 left a comment

mike-chowla left a comment

jeremyvdw commented Mar 18, 2019

piotr-yuxuan commented Mar 18, 2019

Update Adikteev adapter (PR updated) #3391

Update Adikteev adapter (PR updated) #3391

Conversation

piotr-yuxuan commented Dec 18, 2018 • edited Loading

Type of change

Description of change

mike-chowla commented Jan 12, 2019 • edited Loading

piotr-yuxuan commented Jan 17, 2019

mike-chowla commented Jan 30, 2019

piotr-yuxuan commented Feb 1, 2019 • edited Loading

piotr-yuxuan commented Feb 14, 2019 • edited Loading

mike-chowla left a comment

Choose a reason for hiding this comment

mike-chowla commented Feb 19, 2019

piotr-yuxuan commented Feb 19, 2019

piotr-yuxuan commented Feb 21, 2019 • edited Loading

piotr-yuxuan commented Feb 21, 2019

mike-chowla commented Feb 22, 2019

piotr-yuxuan commented Feb 22, 2019

mike-chowla commented Feb 26, 2019

piotr-yuxuan commented Feb 27, 2019

piotr-yuxuan commented Mar 5, 2019 • edited Loading

POST request to https://prebid.adikteev.com/api/prebid/bid

Beautified response

piotr-yuxuan commented Mar 5, 2019

piotr-yuxuan commented Mar 6, 2019

piotr-yuxuan commented Mar 8, 2019

piotr-yuxuan commented Mar 11, 2019 • edited Loading

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

mike-chowla left a comment

Choose a reason for hiding this comment

jeremyvdw commented Mar 18, 2019

piotr-yuxuan commented Mar 18, 2019

POST request to https://prebid.emoteev.io/api/prebid/bid

Beautified response

piotr-yuxuan commented Dec 18, 2018 •

edited

Loading

mike-chowla commented Jan 12, 2019 •

edited

Loading

piotr-yuxuan commented Feb 1, 2019 •

edited

Loading

piotr-yuxuan commented Feb 14, 2019 •

edited

Loading

piotr-yuxuan commented Feb 21, 2019 •

edited

Loading

piotr-yuxuan commented Mar 5, 2019 •

edited

Loading

piotr-yuxuan commented Mar 11, 2019 •

edited

Loading